GH-126599: Remove the PyOptimizer API
#129194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
skip news
interpreter-core
brandtbucher
requested review from
ericsnowcurrently,
markshannon and
savannahostrowski
as code owners
markshannon
reviewed
Jan 23, 2025
Python/bytecodes.c
Outdated
| tier1 op(_SPECIALIZE_JUMP_BACKWARD, (--)) { | ||
| #if ENABLE_SPECIALIZATION | ||
| if (this_instr->op.code == JUMP_BACKWARD) { | ||
| if (tstate->interp->jit) { |
There was a problem hiding this comment.
Suggested change
| if (tstate->interp->jit) { | |
| this_instr->op.code = (tstate->interp->jit) ? JUMP_BACKWARD_JIT : JUMP_BACKWARD_NO_JIT; |
markshannon
reviewed
Jan 28, 2025
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the
PyOptimizerAPI, which also nicely removes the ability to toggle the JIT on or off at runtime. The second commit "specializes"JUMP_BACKWARDso that we don't constantly check whether the JIT is enabled on backedges.This should be covered by the NEWS entry from GH-126853.
_PyOptimizerAPIs #126599